[pacman-dev] [PATCH v3 4/4] pacman/upgrade: Bail early on errors

Sören Brinkmann soeren.brinkmann at gmail.com
Wed Mar 12 00:19:10 EDT 2014


On Wed, 2014-03-12 at 12:06AM -0400, Andrew Gregory wrote:
> On 03/11/14 at 07:29pm, Sören Brinkmann wrote:
> > When an error is detected in a loop, immediately bail out and report the
> > error.
> > 
> > Signed-off-by: Sören Brinkmann <soeren.brinkmann at gmail.com>
> > ---
> >  src/pacman/upgrade.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> -1.  We use retval/continue so that we can give the user errors for
> all targets at once instead of making them repeatedly run pacman.

Makes sense. This should be dropped.

	Thanks,
	Sören


More information about the pacman-dev mailing list