[pacman-dev] [PATCH 1/1] dload: use 'partial file' instead of 'filesize exceeded' message

[Christian Hesse]

Allan McRae <allan at archlinux.org> on Fri, 2014/10/10 13:38:
> On 09/10/14 18:10, Christian Hesse wrote:
> > From: Christian Hesse <mail at eworm.de>
> > 
> > If the server has a package file that is too big (does not match the
> > recorded file size in repository db file) pacman fails with a 'filesize
> > exceeded' message. This is misleading as it looks like pacman is
> > suffering a local problem, for example ulimit on filesize or the like.
> > 
> > This changes the message to 'partial file', which describes the problem
> > a lot better IMHO.
> 
> I don't agree with this change.  If anything, I think the error message
> should be clarified by not relying on the curl string.  Maybe:
> 
> _alpm_log(handle, ALPM_LOG_ERROR,
> 	_("failed retrieving file '%s' from %s : expected download size
> exceeded\n"),

Even better. Will you make the change or do you want a patch?
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20141010/0a6e9dea/attachment.bin>