[pacman-dev] FS#42482 - [paccache] No candidates should not be an error

[Eric Schultz]

>
> ---------- Forwarded message ----------
> From: Florian Pritz <bluewind at xinu.at>
> To: pacman-dev at archlinux.org
> Cc:
> Date: Tue, 28 Oct 2014 10:41:31 +0100
> Subject: Re: [pacman-dev] FS#42482 - [paccache] No candidates should not be an error
> On 28.10.2014 03:44, Eric Schultz wrote:
> >  declare -a cachedirs=() candidates=() cmdopts=() whitelist=() blacklist=()
> > -declare -i delete=0 dryrun=0 filecount=0 move=0 needsroot=0 totalsaved=0
> > verbose=0
> > +declare -i delete=0 dryrun=0 filecount=0 move=0 needsroot=0 noneisok=0
> > totalsaved=0 verbose=0
> >  declare    delim=$'\n' keep=3 movedir= scanarch=
>
> Dan tried to link this earlier but missed the l of html so here's the
> link again: https://www.archlinux.org/pacman/submitting-patches.html
>
> Please use git-send-email and nothing else (especially don't paste a
> patch in gmail) because that is bound to break formatting as can be seen
> above (no indentation, wrapped lines).
>
> Also if you have any comments to add that are not part of a commit use
> git send-email --annotate and add them between the --- marker and the
> diffstat.
>
> BTT: I also don't see why paccache should exit 1. Looks like this was in
> the initial version Dave wrote so maybe he can chime in?
>

Ok, I'll try to figure-out configuring git send-email given my network
constraints.

As for whether no candidates should just exit 0 I would agree. However
since paccache with it's current behaviour is out in the wild I
figured adding a flag that provides alternate behaviour would be more
prudent than changing the current behaviour (in case anyone relies on
it). I'll happily go back and change just one character in the
original version and re-submit if you all agree that's what's to be
done.

--
Headed for the second star to the right and straight on 'til morning...

  Eric Schultz (aka schultzter)

  Read more at 2FatDads