[pacman-dev] [PATCH] Revert "Remove log_cb, add ALPM_EVENT_LOG instead"

Allan McRae allan at archlinux.org
Mon Sep 29 12:41:47 UTC 2014


On 29/09/14 07:45, Andrew Gregory wrote:
> Moving logging to the event callback caused warnings
> under clang due to non-literal format strings and
> silenced all log messages when --print was used.
> 
> This reverts commit cd793c5ab7689cc8cbc18277375b368060e5acfe.
> 
> Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
> 
> Conflicts:
> 	lib/libalpm/alpm.h
> 	src/pacman/callback.c
> ---
> 
> Making sure this doesn't fall through the cracks prior
> to 4.2.  Previous discussion here:
> https://lists.archlinux.org/pipermail/pacman-dev/2014-June/019136.html
> 

Completely forgot about this.   I am happy for the to be reverted.  If a
complete solution to make logging an even happens later, I will be happy
to include it.

Allan


More information about the pacman-dev mailing list