[pacman-dev] [PATCH] makepkg-template: support multiple --template-dirs

[Florian Pritz]

On 22.04.2015 20:37, Dominik Fischer wrote:
> Especially when maintaining local templates in addition to the ones
> stored in /usr/share/makepkg-template, it can be useful to include
> templates stored in multiple different locations into one PKGBUILD. This
> patch makes this possible by allowing --template-dir to be specified
> multiple times.
> 
> This also introduces a dedicated error message when a template cannot be
> found, in contrast to the already existing "Couldn't detect version for
> template '%s'".
> 
> If a template of the same name is present in more than one of the given
> directories, the last one always takes precedence.
> 
> Neither the default behaviour without the option given, nor the handling
> of a single template dir is changed.
> 
> Signed-off-by: Dominik Fischer <d.f.fischer at web.de>
> ---
> I reused some already translated strings for the new error message.  Perhaps a
> new string should be introduced here, but I do not know what to do to update
> the translation files appropriately.

Just use gettext in your code, the translation files will be updated
upon release.

Also please make sure to adapt the existing tests (you broke a couple)
and maybe add a test or two. They are in
./test/scripts/makepkg-template-tests/. Run them with make check and
make distcheck (make sure both work).


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20150423/1ee6e3bf/attachment.asc>