[pacman-dev] [PATCH] alpm_run_chroot: remove dead code

Andrew Gregory andrew.gregory.8 at gmail.com
Sat Dec 5 16:31:43 UTC 2015


Removes a leftover error message from when fdopen and fgets were used to
read from the pipe.

Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
---
 lib/libalpm/util.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/lib/libalpm/util.c b/lib/libalpm/util.c
index 7e8f85e..3824d13 100644
--- a/lib/libalpm/util.c
+++ b/lib/libalpm/util.c
@@ -705,11 +705,6 @@ int _alpm_run_chroot(alpm_handle_t *handle, const char *cmd, char *const argv[],
 			}
 		}
 
-		/* report error from above after the child has exited */
-		if(retval != 0) {
-			_alpm_log(handle, ALPM_LOG_ERROR, _("could not open pipe (%s)\n"), strerror(errno));
-			goto cleanup;
-		}
 		/* check the return status, make sure it is 0 (success) */
 		if(WIFEXITED(status)) {
 			_alpm_log(handle, ALPM_LOG_DEBUG, "call to waitpid succeeded\n");
-- 
2.6.3


More information about the pacman-dev mailing list