[pacman-dev] [PATCH 2/3] Add events ALPM_EVENT_HOOK_{START, DONE}

[Allan McRae]

On 15/12/15 02:58, Olivier Brunel wrote:
> On Mon, 14 Dec 2015 10:59:48 -0500
> Andrew Gregory <andrew.gregory.8 at gmail.com> wrote:
> 
>> On 12/14/15 at 01:45pm, Allan McRae wrote:
>>> From: Olivier Brunel <jjk at jjacky.com>
>>>
>>> Add events to let frontends know when hooks are being processed
>>> (and when it's done), as that might be useful to update the UI.
>>>
>>> Signed-off-by: Olivier Brunel <jjk at jjacky.com>
>>> ---
>>>  lib/libalpm/alpm.h    | 24 +++++++++++++++++++++++-
>>>  lib/libalpm/hook.c    | 11 +++++++++--
>>>  lib/libalpm/hook.h    |  7 +------
>>>  src/pacman/callback.c |  6 ++++++
>>>  4 files changed, 39 insertions(+), 9 deletions(-)  
>> ...
>>> diff --git a/src/pacman/callback.c b/src/pacman/callback.c
>>> index 7a21b22..37966ab 100644
>>> --- a/src/pacman/callback.c
>>> +++ b/src/pacman/callback.c
>>> @@ -167,6 +167,11 @@ void cb_event(alpm_event_t *event)
>>>  		return;
>>>  	}
>>>  	switch(event->type) {
>>> +		case ALPM_EVENT_HOOK_START:
>>> +			colon_printf(_("Running %s hooks...\n"),
>>> +					event->hook.when ==
>>> ALPM_HOOK_PRE_TRANSACTION
>>> +					? _("pre-transaction") :
>>> _("post-transaction"));  
>>
>> Is there any reason to break up this string like this?  Splitting it
>> and using substitution adds an extra string to be translated and
>> I would think translators would benefit from the extra context of the
>> full message.
> 
> Nope, you're right two full messages would be better.
> 
> Allan: do you want me to send an updated version of this?
> 

I'll handle this while rebasing.

Allan