[pacman-dev] [PATCH] Disable directory ownership warnings

[Allan McRae]

On 04/02/15 15:11, Andrew Gregory wrote:
> On 02/04/15 at 02:53pm, Allan McRae wrote:
>> There was a lot of confusion regarding these warnings, particularly for
>> packages that create users post_install and then chown the directories.
>>
>> Signed-off-by: Allan McRae <allan at archlinux.org>
>> ---
> 
>  add.c: In function ‘extract_single_file’:
>  add.c:231:9: error: unused variable ‘entrygid’ [-Werror=unused-variable]
>     gid_t entrygid = archive_entry_gid(entry);
>          ^
>  add.c:230:9: error: unused variable ‘entryuid’ [-Werror=unused-variable]
>     uid_t entryuid = archive_entry_uid(entry);
> 
> Also, this doesn't need to remove the permission check, just the
> ownership check.  I don't think there's any valid reason for install
> scripts to chmod anything, and we've had that check for quite a while.
> 

I had done both those things...   and then forgot to regenerate the
patch before sending!

Fixed on my patchqueue branch.

Allan