[pacman-dev] [PATCH] Fix memory leaks in dump_pkg_ful

Allan McRae allan at archlinux.org
Tue Feb 24 10:46:28 UTC 2015


Leaks when using -Sii with package signatures

Signed-off-by: Allan McRae <allan at archlinux.org>
---
 src/pacman/package.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/pacman/package.c b/src/pacman/package.c
index 14a7b9f..33184bd 100644
--- a/src/pacman/package.c
+++ b/src/pacman/package.c
@@ -201,6 +201,7 @@ void dump_pkg_full(alpm_pkg_t *pkg, int extra)
 			alpm_decode_signature(base64_sig, &decoded_sigdata, &data_len);
 			alpm_extract_keyid(config->handle, alpm_pkg_get_name(pkg),
 					decoded_sigdata, data_len, &keys);
+			free(decoded_sigdata);
 		} else {
 			keys = alpm_list_add(keys, _("None"));
 		}
@@ -208,6 +209,10 @@ void dump_pkg_full(alpm_pkg_t *pkg, int extra)
 		string_display(_("MD5 Sum        :"), alpm_pkg_get_md5sum(pkg), cols);
 		string_display(_("SHA-256 Sum    :"), alpm_pkg_get_sha256sum(pkg), cols);
 		list_display(_("Signatures     :"), keys, cols);
+
+		if(base64_sig) {
+			FREELIST(keys);
+		}
 	} else {
 		list_display(_("Validated By   :"), validation, cols);
 	}
-- 
2.3.0


More information about the pacman-dev mailing list