[pacman-dev] Bazaar branch check in makepkg

Florian Pritz bluewind at xinu.at
Thu Jan 8 23:10:19 UTC 2015

On 08.01.2015 23:18, David Macek wrote:
> I'm posting this on behalf of an MSYS2 user.

I appreciate you trying to send patches upstream, but you'll likely get
more/better responses if you send the patch with git-send-email so it's
easy to review/comment on. Also it's probably better if the author sends
it and participates in the discussion (unless you really like playing
the middleman...).

If they don't want the list traffic, that's fine. Mailman has an option
so you don't receive any mails, but still post to the list. Just be sure
to mention it so people can CC you.

> I'm not sure why this kind of code is used but it looks pretty
> useless for any VCS at all.

commit c926c39b0481ec3db931fff1f86db0c49d78976b quote below

> Author: Mohammad Alsaleh <msal at i2pmail.org>
> Date:   Sun Aug 12 00:24:57 2012 +0000
>     makepkg: check if $dir is a local clone of the right git repo
>     Before this patch, makepkg does not check if $dir is a local clone of
>     the right repo.
>     For example, git fetch would be run even if $dir is not a local
>     bare clone of a git repo in present in source(), but a subdir of
>     a checked-out one. That means makepkg can potentially fetch from
>     a completely unrelated remote and update completely unrelated
>     dirs/files.
>     This patch adds a check to make sure we are fetching from the right
>     remote.
>     Signed-off-by: Mohammad Alsaleh <msal at i2pmail.org>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20150109/6ac62c82/attachment.bin>

More information about the pacman-dev mailing list