[pacman-dev] [PATCH] makepkg: fix stripping static libraries when shared use absolute symlinks

Allan McRae allan at archlinux.org
Sat Jan 10 10:09:55 UTC 2015


s/stripping/removing/


On 10/01/15 19:46, Allan McRae wrote:
> When a shared library uses an absolute symlink for its its .so file, the check
> if the shared version of a static library exists fails.  Test for the presence
> of a broken symlink too.
> 
> Signed-off-by: Allan McRae <allan at archlinux.org>
> ---
> 
> A workaround for bad software, but we need to do this unless we want to ensure
> all symlinks are relative
> 
>  scripts/makepkg.sh.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
> index 880e778..be12940 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -1833,7 +1833,7 @@ tidy_install() {
>  	# check existence of backup files
>  	local file
>  	for file in "${backup[@]}"; do
> -		if [[ ! -f $file ]]; then
> +		if [[ ! -f $file && ! -h $file ]]; then
>  			warning "$(gettext "%s entry file not in package : %s")" "backup" "$file"
>  		fi
>  	done
> 


More information about the pacman-dev mailing list