[pacman-dev] [PATCH v2 1/1] add option to optimize PNG images with optipng

[Christian Hesse]

Dave Reisner <d at falconindy.com> on Sat, 2015/01/24 15:38:
> > +                       if [[ $(file --brief --mime-type "$png") =
> > 'image/png' ]]; then
> > +                               optipng $OPTIPNGFLAGS "$png" &>/dev/null
> > ||
> > +                                       warning "$(gettext "Could not
> > optimize PNG image : %s")" "${png/$pkgdir\//}"
> 
> I really dislike that we're using a simple var instead of an array here. Is
> there a strong reason not to do this?

So you would prefer "${OPTIPNGFLAGS[@]}"? Again, this is adopted from upx and
UPXFLAGS which is just a simple var.

I am fine with using an array, in fact I would prefer it. Want a new patch?
How about UPXFLAGS? Do we want to change it there?
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20150124/3e4a0fc3/attachment-0001.asc>