[pacman-dev] [PATCH] Add makepkg option --printproducts; fix bug #42150

[Florian Pritz]

>> > From: Ivy Foster <joyfulgirl at archlinux.us>

I'm not really sure why that is here. Did you set the envelope sender in
git (git config --global sendemail.envelopesender) or am I missing some
difference between the two addresses?

>> New contributor - yay!
>> > [patch]
>> [notes]
> 
> Thanks! I'll fix it up as you've suggested. When that's
> done, should I send the changes as a patch that's a sequel
> to the first, or should I create a unified patch with
> everything?

Send the updated patch with subject [PATCH v2] instead of [PATCH] (use
the -v2 option of git format-patch) and list the changes after the "---"
marker.

That list of changes is mainly a habit of mine, but it allows the
readers to easily check if all of their concerns should have been
addressed. Not so much an issue here so feel free to omit it. I'm not
sure how others on this list feel about it.

Also use --in-reply-to with the Message-ID of your initial patch (or
write In-Reply-To: <...> in the generated email's headers). You can find
the id in the email source and you can probably configure your client to
display additional headers instead of simply From/To/CC/Subject/... .
With that header we get proper threading so it's easy to review
discussion and previous versions of the patch.

Of course those options also work with git send-email if you use that.
Be sure to use --annotate to be able to add the comment after the marker
though.

Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20150320/1acba483/attachment.asc>