[pacman-dev] [PATCH 3/3] makepkg: Empty/create only $pkgdir's relevant to current PKGBUILD (unless CLEANUP is set)

Allan McRae allan at archlinux.org
Wed Mar 25 09:09:16 UTC 2015


On 25/03/15 18:09, David Macek wrote:
> On 25. 3. 2015 6:13, Allan McRae wrote:
>>> I've thought about it, and I like more the version that defers deleting $pkgdir's until it is really needed. Clearing all $pkgdir's at once would produce different results in case a failure occurs before all packaging function are called.
>>>
>>
>> If packaging files, you could end up with two $pkgdir from the new
>> package (one broken) and one from the old package - I do not like that
>> inconsistency.  Why would you want to keep the old package $pkgdir if
>> you are intending to replace it?
> 
> Hmm. You're right -- if some $pkgdir is important to me, running makepkg that needs to overwrite it would be silly.
> 
> Shall I make patch v2?
> 

That would be great thanks!

A


More information about the pacman-dev mailing list