[pacman-dev] [PATCH] Fixed wrong alignment in the italian translation.
ambrevar at gmail.com
Fri Oct 16 14:48:14 UTC 2015
On 15-10-15 21:11:22, Allan McRae wrote:
> Mostly the last one I think... It has been more than three years since
> I looked at this.
Are you already there, in 2016? :D
Jokes aside, I had a look at the code + the patch set.
Patch 2 and 3 do some minor refactoring:
* Compute 'len' early.
I don't see the point, it is less clear and wastes some cycles.
* Move some *_display function from util.c to package.c and make them static.
This makes the code base less uniform. I don't think that the potential (?) code
optimization is worth it.
* Rename 'cols' to maxcols'.
* Replace the indentation loop with a printf("%-*s"...).
Patch 4 does more important refactoring. It moves a lot of code out of util.c to
the new termio.c. Some functions have been added, which possibly factor some
redundant parts. (I would need to study the code a little bit more to make sure
of this). The resulting code base is bigger: 240 insertions(+), 154
deletions(-), so I am not sure where the gain is.
* I could not see anything related to alighment. I suppose the patch set was
laying the ground work for further improvements.
* Do you think it is worth basing future work on this patch set?
I would say no at first glance.
* I can see 2 ways to fix the alignment issue:
1) Remove the (regex) " *:" in every string including .po's and pad spaces
dynamically. The current .po maintenance seems rather shallow, and this will
keep alignment broken for most locales for a while. (Actually, it will make it
2) Keep existing strings unchanged, ignore everything that matches " *:" and
align from there. This is a bit dirty in the sense that this special case will
remain even after the " *:" are gone from the .po.
I'd rather go for 1). Do you think it would be easy to batch process all .po's
on Transifex? I have absolutely no clue, I've never used it.
More information about the pacman-dev