[pacman-dev] [PATCH 3/3] Align titles automatically in information display
Pierre Neidhardt
ambrevar at gmail.com
Sat Oct 17 16:49:14 UTC 2015
On 15-10-17 09:11:02, Dave Reisner wrote:
> On Sat, Oct 17, 2015 at 12:04:11PM +0200, Pierre Neidhardt wrote:
> > Signed-off-by: Pierre Neidhardt <ambrevar at gmail.com>
> > +#define TITLE_MAXLEN 64
>
> Surely, you examined the POT files to determine this value. Could you
> leave behind a comment explaining as much so that it's clear what this
> relates to for future readers?
Actually I did! :) Longest title string is less than 26 characters long. But you
are right, I will add a comment in the next patch.
This raises a good question however: what would be a good maximum value for
titles? (Titles longer than TITLE_MAXLEN get truncated.)
--
Pierre Neidhardt
Mind your own business, then you don't mind mine.
More information about the pacman-dev
mailing list