[pacman-dev] [PATCH v2] Make DUFLAGS be overrideable during configure

[Alastair Hughes]

On 8/30/16, Allan McRae <allan at archlinux.org> wrote:
> On 20/08/16 06:52, Alastair Hughes wrote:
>> Not all du implementations on linux accept --apparent-size, so let the
>> user configure the arguments passed to du if required.
>>
>> This fixes FS#47943.
>>
>> Signed-off-by: Alastair Hughes <hobbitalastair at gmail.com>
>> ---
>
> Why this approach over the previous style of:
>
> DUFLAGS="${DUFLAGS- -sk}"
>
> ?

I decided that the prior approach was messy due to the new default in
the case statement. I thought that it seemed less messy and more
consistent to use the case statement to set a default and then use
that only if DUFLAGS was not set.

Looking at this again, I realize that I've moved some things around
more than they should be. I apologize for the messiness :( - I'll try
to be more careful. Thanks for looking at this!

Alastair Hughes