[pacman-dev] [PATCH] libalpm, fix leak if malloc fails in be_sync
andrew.gregory.8 at gmail.com
Mon Jan 4 09:55:18 UTC 2016
On 01/04/16 at 02:54pm, Allan McRae wrote:
> On 11/11/15 05:52, Rikard Falkeborn wrote:
> > ---
> > lib/libalpm/be_sync.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> This needs reworked due to other changes made to that file. But I seem
> to recall Andrew had a comment on this...
> Andrew - did I recall correctly?
I think my only real issue with the patch itself was that it moved
_alpm_handle_unlock when it shouldn't have. At this point this patch
should just remove RET_ERR, manually set pm_errno, and break or
continue the loop.
More information about the pacman-dev