[pacman-dev] [PATCH] Fix out of boundary reads in pacsort.

Allan McRae allan at archlinux.org
Mon Jun 13 06:01:17 UTC 2016


On 11/06/16 17:27, Tobias Stoeckmann wrote:
> On Fri, Jun 10, 2016 at 07:11:16PM -0400, Andrew Gregory wrote:
>> I was saying that your rationale for just dropping support for -t '\0'
>> was incorrect.  NUL not being legal in a path name is irrelevant.
> 
> Yup, it's irrelevant. The relevant part is using strndup() with an input
> line. Maybe you want to adjust that one?
> 

Fixing that strndup is preferable.  I want to keep the ability to handle
\0 delimited fields given that is what pacman --machinereadable does
(despite that option not being ubiquitous at the moment...)

Allan


More information about the pacman-dev mailing list