[pacman-dev] [PATCH] libmakepkg: extract functions for integrity checking

[Allan McRae]

On 01/05/16 06:00, Ashley Whetter wrote:
> Signed-off-by: Ashley Whetter <ashley at awhetter.co.uk>
> ---
>  scripts/Makefile.am                          |   4 +
>  scripts/libmakepkg/.gitignore                |   2 +
>  scripts/libmakepkg/integrity.sh.in           |  43 +++
>  scripts/libmakepkg/integrity/checksum.sh.in  | 210 +++++++++++++
>  scripts/libmakepkg/integrity/signature.sh.in | 239 +++++++++++++++
>  scripts/libmakepkg/util/pkgbuild.sh.in       |  18 ++
>  scripts/makepkg.sh.in                        | 428 ---------------------------
>  7 files changed, 516 insertions(+), 428 deletions(-)
>  create mode 100644 scripts/libmakepkg/integrity.sh.in
>  create mode 100644 scripts/libmakepkg/integrity/checksum.sh.in
>  create mode 100644 scripts/libmakepkg/integrity/signature.sh.in
> 

A few comments that should be fast to implement:

- These has translatable strings so will need added to
scripts/po/POTFILES.in

- Capitalise PGP in signature.sh.in header

- Can you split "checksum.sh" into "verify_checksum" and
"generate_checksum"?  Same for "signature" too (even though this is a
single function). I think those function don't really group together well.

- Use git blame to look at the sections you are moving and what years
that code was written (excluding trivial things like brackets).  Use
that to set the year range.

Thanks,
Allan