[pacman-dev] [PATCH 1/4] makepkg: fix find_lib{depends, provides} results

Andrew Gregory andrew.gregory.8 at gmail.com
Sat Nov 5 22:08:14 UTC 2016


Neither function was checking for the existence of actual results before
calling printf, resulting in them returning a list with a single empty
value if there were no depends/provides.

Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
---
 scripts/makepkg.sh.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index 02398cf..714b376 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -494,7 +494,7 @@ find_libdepends() {
 	done
 
 	if (( sodepends == 0 )); then
-		printf '%s\n' "${depends[@]}"
+		(( ${#depends[@]} )) && printf '%s\n' "${depends[@]}"
 		return;
 	fi
 
@@ -543,7 +543,7 @@ find_libdepends() {
 		esac
 	done
 
-	printf '%s\n' "${libdepends[@]}"
+	(( ${#libdepends[@]} )) && printf '%s\n' "${libdepends[@]}"
 }
 
 
@@ -594,7 +594,7 @@ find_libprovides() {
 		fi
 	done
 
-	printf '%s\n' "${libprovides[@]}"
+	(( ${#libprovides[@]} )) && printf '%s\n' "${libprovides[@]}"
 }
 
 write_pkginfo() {
-- 
2.10.2


More information about the pacman-dev mailing list