[pacman-dev] shellcheck conformity for makepkg
bluewind at xinu.at
Sat Oct 8 08:56:25 UTC 2016
On 07.10.2016 03:52, Alad Wenter wrote:
> The idea would be that each warning, if applicable, is addressed in a
> separate patch.
Good idea. If a warning appears multiple times and requires different
ways of dealing with it in certain situations, please split that into
multiple patches. It greatly simplifies reviewing if all the changes in
one patch do exactly the same.
I've quickly reviewed the proposed changes and they look good in
general. Patches will be reviewed anyways so I'd say just go ahead.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 825 bytes
Desc: OpenPGP digital signature
More information about the pacman-dev