[pacman-dev] [PATCH v2] makepkg: Move parseopts from library to libmakepkg

[Alad Wenter]

On 10/08/2016 01:01 PM, Rikard Falkeborn wrote:
> 2016-10-08 7:18 GMT+02:00 Alad Wenter <alad at archlinux.info>:
>
>> Signed-off-by: Alad Wenter <alad at archlinux.info>
>> ---
>>   v2: Add missing signoff.
>>
>>   scripts/libmakepkg/util/option.sh | 157 ++++++++++++++++++++++++++++++
>> ++++++++
>>   scripts/library/README            |  20 -----
>>   scripts/library/parseopts.sh      | 137 ---------------------------------
>>   scripts/makepkg.sh.in             |   2 -
>>   4 files changed, 157 insertions(+), 159 deletions(-)
>>   delete mode 100644 scripts/library/parseopts.sh
>>
> parseopts.sh is used in a couple of other scripts, is referenced in a
> couple of makefiles, and even has test cases. Each of these would need to
> be changed. See below.
>
> Also, IMO, for a change like this, a short motivation should go into the
> commit message (one sentence may be enough).
>
> Moving parseopts to libmakepkg would make a couple of "pacman"-scripts
> depend on libmakepkg (instead of library), which feels wrong, but feel free
> to ignore me, I'm not a pacman dev. :)
>
>   [~/code/pacman]./autogen.sh && ./configure && make
>   ...
>   make[3]: *** No rule to make target 'library/parseopts.sh', needed by
> 'makepkg'.  Stop.
>   make[2]: *** [Makefile:623: all-recursive] Error 1
>   make[1]: *** [Makefile:969: all-recursive] Error 1
>
>   git grep parseopts\.sh -- '*' ':!scripts/po/*'
>   contrib/Makefile.am:paccache: $(srcdir)/paccache.sh.in
> $(top_srcdir)/scripts/library/parseopts.sh
> $(top_srcdir)/scripts/library/size_to_human.sh
>   contrib/bacman.sh.in:m4_include(../scripts/library/parseopts.sh)
>   contrib/paccache.sh.in:m4_include(../scripts/library/parseopts.sh)
>   scripts/Makefile.am:    library/parseopts.sh \
>   scripts/Makefile.am:    $(srcdir)/library/parseopts.sh \
>   scripts/Makefile.am:    $(srcdir)/library/parseopts.sh
>   scripts/Makefile.am:    $(srcdir)/library/parseopts.sh
>   scripts/Makefile.am:    $(srcdir)/library/parseopts.sh \
>   scripts/libmakepkg/util/option.sh:# parseopts.sh:
>   scripts/pacman-db-upgrade.sh.in:m4_include(library/parseopts.sh)
>   scripts/pacman-key.sh.in:m4_include(library/parseopts.sh)
>   scripts/pkgdelta.sh.in:m4_include(library/parseopts.sh)
>   test/scripts/parseopts_test.sh:lib=${1:-${PMTEST_SCRIPTLIB_DIR}parseopts.sh}
>
> /Rikard

Thanks for your reply. Good point about the other scripts, but I'm not 
sure about contrib since those were proposed for removal...

https://lists.archlinux.org/pipermail/pacman-dev/2016-October/021533.html

Alad