[pacman-dev] [PATCH v5] makepkg: Move parseopts from library to libmakepkg

Allan McRae allan at archlinux.org
Wed Oct 12 04:28:59 UTC 2016


On 10/10/16 18:47, Alad Wenter wrote:
> parseopts is used in makepkg and other scripts such as pacman-key as a
> getopt replacement.
> 
> Instead of including it in those scripts via a macro, move it to
> libmakepkg/util/parseopts.sh and have scripts source this file where
> appropriate.
> 
> To keep the parseopts test, a new variable was introduced:
> PM_LIBMAKEPKG_DIR
> 
> Signed-off-by: Alad Wenter <alad at archlinux.info>
> ---
> v5: update README


I did a minor rebase to get this to apply.  Everything is fine with the
patch apart from...

FAIL: test/scripts/pacman-db-upgrade-v9

The problem is that the in tree build is not able to determine library
location.  This happened with makepkg too, and I solved it with a
wrapper function.  Let me see if I can generalise this...

A


More information about the pacman-dev mailing list