[pacman-dev] [PATCH v2] makepkg: print filenames and line numbers of references to $srcdir & $pkgdir in built package
Ivy Foster
ivy.foster at gmail.com
Sat Oct 15 02:27:53 UTC 2016
On 14 Oct 2016, at 10:07 pm -0400, Andrew Gregory wrote:
> We're not very strict about this, but please try to keep the first
> line of the commit message fairly short, ideally around 50 characters.
Noted, thanks.
> On 10/14/16 at 08:21pm, ivy.foster at gmail.com wrote:
> > From: Ivy Foster <ivy.foster at gmail.com>
> + mapfile -t refs < <(find "$pkgdir" -type f -exec grep -n "${!var}" {} +)
> For packages with just a single file this won't print the name of the
> matching file. GNU grep has -H for this, but it's not POSIX. What
> about including /dev/null as an argument to grep so that it always has
> more than one file?
Ah, you're quite right. I'll fiddle with that and resubmit tomorrow, then.
Ivy
More information about the pacman-dev
mailing list