[pacman-dev] [PATCH] Give a "success!" message on database check

[Patrick Eigensatz]

Hi Andrew! Thank you for your feedback!

I'll change "success!"  to  "No errors were found" if this is okay.

I will also try to change the output of --help and also adjust the man page.

Ps:  Is it possible to tell git send-email to reply to the message with
this ID?

Thanks again
Patrick

Andrew Gregory <andrew.gregory.8 at gmail.com> schrieb am Mi., 28. Sep. 2016,
21:19:

> On 09/25/16 at 02:02pm, Patrick Eigensatz wrote:
> > 'pacman -Dk' prints a "success!" message if there were no errors.
> > It is possible to suppress the output using the '-q / --quiet' flag.
> >
> > This implements the feature discussed at
> https://bugs.archlinux.org/task/50087
> >
> > Signed-off-by: Patrick Eigensatz <patrick.eigensatz at gmail.com>
> > ---
> >  src/pacman/database.c | 4 ++++
> >  src/pacman/pacman.c   | 4 ++++
> >  2 files changed, 8 insertions(+)
> >
> > diff --git a/src/pacman/database.c b/src/pacman/database.c
> > index 0197903..5143031 100644
> > --- a/src/pacman/database.c
> > +++ b/src/pacman/database.c
> > @@ -286,6 +286,10 @@ int pacman_database(alpm_list_t *targets)
> >               } else {
> >                       ret = check_db_sync();
> >               }
> > +
> > +             if(ret == 0 && !config->quiet) {
> > +                     printf(_("success!\n"));
>
> Let's make this a little more specific; something like "no errors
> found".
>
> > +             }
> >       }
> >
> >       if(config->flags & (ALPM_TRANS_FLAG_ALLDEPS |
> ALPM_TRANS_FLAG_ALLEXPLICIT)) {
> > diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c
> > index be52d1b..b477df7 100644
> > --- a/src/pacman/pacman.c
> > +++ b/src/pacman/pacman.c
> > @@ -466,6 +466,10 @@ static int parsearg_database(int opt)
> >               case 'k':
> >                       (config->op_q_check)++;
> >                       break;
> > +             case OP_QUIET:
> > +             case 'q':
> > +                     config->quiet = 1;
> > +             break;
>
> The man page and --help need to be updated to reflect this.
>
> >               default:
> >                       return 1;
> >       }
> > --
> > 2.10.0
>