[pacman-dev] [PATCH] Check for all return values of _alpm_key_in_keychain

[Allan McRae]

On 21/04/17 14:07, David Phillips wrote:
> This fixes a bug I encountered with a GPG keyring where the
> key id used to locate a key in the keyring was ambiguous within
> my keychain.
> 
> This commit ensures that all valid return values are checked to
> catch this and related error cases rather than incorrectly taking
> an error case to mean the key was found, since this is rarely going
> to be the case.

Can you tell me what happens both before and after this patch with
ambiguous key IDs.   Also, what happens if you only have one of the keys
in the keyring and want to match the other?

Perhaps we also need to look at matching the whole key fingerprint...

Cheers,
Allan