[pacman-dev] [PATCH] Provide a better guess about who the packager is.

[Kieran Colford]

Really????? That is a problem then.

Could we improve that feature to check that the PACKAGER variable matches a
userid of the key that signs said package? That would not only be a
stronger requirement (forcing a correct makepkg.conf, rather than one
that's just set so you're running around trying to find "hfkskxfjks"), but
it would also remove the reliance on makepkg's implementation defined
behavior.

I could try submitting a patch to the relevant mailing list of you think
it's worthwhile.

On Wed, Feb 1, 2017, 9:19 AM Dave Reisner, <d at falconindy.com> wrote:

On Wed, Feb 01, 2017 at 01:48:09PM +0000, Kieran Colford wrote:
> Exactly, if they have PACKAGER set then we don't make any guesses at all,
> they've already told us exactly what they want.

But this patch gets rid of a lovely feature in arch's db-scripts which
causes an unset PACKAGER variable (resulting in "Unknown Packager") to
reject packages from being pushed into the repos. Your patch breaks
that, and we end up having to hunt down whomever "noclaf at rampage" is to
make them fix their ~/.makepkg.conf.

> On Wed, Feb 1, 2017, 8:43 AM Dave Reisner, <d at falconindy.com> wrote:
>
> > On Feb 1, 2017 08:33, "Kieran Colford" <kieran at kcolford.com> wrote:
> >
> > Would you care to share with us what pile of shit it returns? I can't
fix
> > something when I don't know what's wrong.
> >
> > I never suggested that we work around laziness, people should absolutely
> > configure their system properly (I personally think violators should be
> > punished with regular kernel panics, but I don't think Linus will
accept my
> > patch).
> >
> > I'm just trying to give default values that conform to what a user
expects
> > to see: if they added a real name on account creation then it should
show
> > up wherever a real name is needed, if they set the EMAIL environment
> > variable then software should assume that's the user's email and use it.
> > Those are both recommended by the wiki too.
> >
> >
> > And if they set PACKAGER it leaks into makepkg just the same, but
better?
> >
> >
> >
> > On Wed, Feb 1, 2017, 12:47 AM Allan McRae, <allan at archlinux.org> wrote:
> >
> > > On 01/02/17 08:10, Kieran Colford wrote:
> > > > The system usually has enough information in various places to guess
> > > > the name and email of the person running the makepkg script. Use
these
> > > > instead of defaulting to "Unknown Packager" to minimize
configuration
> > > > necessary by the user.  This particular implemenation should provide
> > > > relatively good guess that's compatible with other programs
> > > > (i.e. git).
> > > >
> > > > Signed-off-by: Kieran Colford <kieran at kcolford.com>
> > >
> > > This returns a pile of shit on my system....  We are not going to work
> > > around laziness.
> > >
> > > A
> > >
> > --
> >
> > Signed, Kieran Colford
> >
> --
>
> Signed, Kieran Colford

-- 

Signed, Kieran Colford