[pacman-dev] [PATCH] hooks: warn if reassignment overwrites previous setting
git at stefan-klinger.de
git at stefan-klinger.de
Tue Jan 3 15:53:53 UTC 2017
On 2017-Jan-03, Silvan Jegen wrote with possible deletions:
> On Mon, Jan 2, 2017 at 4:19 PM, Stefan Klinger <git at stefan-klinger.de> wrote:
> > In hook definition files, repeated assignment to Description, Exec,
> > Type, and When silently overwrote previous settings. This yields a
> > warning now.
>
> Looks good to me but I have not tested it.
>
> One nitpick below.
>
> > +self.description = "Hook using multiple Description's"
>
> The 's looks like a possessive 's to me (instead of a plural). Writing
>
> +self.description = "Hook using multiple 'Description's"
That's how it was intended. I'll fix it.
--
http://stefan-klinger.de o/X
Send plain text messages only, not exceeding 32kB. /\/
\
More information about the pacman-dev
mailing list