[pacman-dev] [PATCH 1/4] util/pkgbuild: guard against unset variable

Allan McRae allan at archlinux.org
Thu Mar 2 04:37:21 UTC 2017


On 26/02/17 03:21, Andrew Gregory wrote:
> Allows use under 'set -u'.
> ---
>  scripts/libmakepkg/util/pkgbuild.sh.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/libmakepkg/util/pkgbuild.sh.in b/scripts/libmakepkg/util/pkgbuild.sh.in
> index 2a4bd3af..08b35f53 100644
> --- a/scripts/libmakepkg/util/pkgbuild.sh.in
> +++ b/scripts/libmakepkg/util/pkgbuild.sh.in
> @@ -18,7 +18,7 @@
>  #   along with this program.  If not, see <http://www.gnu.org/licenses/>.
>  #
>  
> -[[ -n "$LIBMAKEPKG_UTIL_PKGBUILD_SH" ]] && return
> +[[ -n "${LIBMAKEPKG_UTIL_PKGBUILD_SH:-}" ]] && return
>  LIBMAKEPKG_UTIL_PKGBUILD_SH=1
>  
>

Is this going to need done for every file that you test?  I'd prefer one
big patch if so.

A


More information about the pacman-dev mailing list