[pacman-dev] [PATCH 4/4] add basic makepkg test

[Allan McRae]

On 26/02/17 03:21, Andrew Gregory wrote:
> ---
>  Makefile.am                         |   6 +-
>  configure.ac                        |   2 +
>  test/makepkg/Makefile.am            |   9 +++
>  test/makepkg/README                 |  15 ++++
>  test/makepkg/test_functions.sh      | 143 ++++++++++++++++++++++++++++++++++++
>  test/makepkg/tests/Makefile.am      |   7 ++
>  test/makepkg/tests/TESTS            |   4 +
>  test/makepkg/tests/dbfiles.sh       |  35 +++++++++
>  test/makepkg/tests/dotfiles.sh      |  33 +++++++++
>  test/makepkg/tests/pkgbuild.sh      |  53 +++++++++++++
>  test/makepkg/tests/util-pkgbuild.sh |  35 +++++++++
>  11 files changed, 341 insertions(+), 1 deletion(-)
>  create mode 100644 test/makepkg/Makefile.am
>  create mode 100644 test/makepkg/README
>  create mode 100644 test/makepkg/test_functions.sh
>  create mode 100644 test/makepkg/tests/Makefile.am
>  create mode 100644 test/makepkg/tests/TESTS
>  create mode 100755 test/makepkg/tests/dbfiles.sh
>  create mode 100755 test/makepkg/tests/dotfiles.sh
>  create mode 100755 test/makepkg/tests/pkgbuild.sh
>  create mode 100755 test/makepkg/tests/util-pkgbuild.sh
> 

Looks good to me.  Tests are a bit more complicated to make than pacman
ones, but I will manage!

Try not to use realpath in the script.  This is not portable (there were
issues with BSD/OSX from memory).

Allan