[pacman-dev] [PATCH 5/5] remove unused byte from user agent buffer

Andrew Gregory andrew.gregory.8 at gmail.com
Wed May 10 22:54:57 UTC 2017


snprintf prints at most n bytes including the terminating '\0'.  The
extra reserved byte was never being used.

Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
---
 src/pacman/pacman.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c
index 11b7e6f0..8c7f715e 100644
--- a/src/pacman/pacman.c
+++ b/src/pacman/pacman.c
@@ -269,7 +269,7 @@ static void localize(void)
  */
 static void setuseragent(void)
 {
-	char agent[101];
+	char agent[100];
 	struct utsname un;
 	int len;
 
-- 
2.12.2


More information about the pacman-dev mailing list