[pacman-dev] [PATCH 1/2] makepkg: implement error codes

[Allan McRae]

On 15/09/17 08:58, ivy.foster at gmail.com wrote:
> index 20e9dd7e..8ef3c48d 100644
> --- a/scripts/makepkg.sh.in
> +++ b/scripts/makepkg.sh.in
> @@ -87,6 +87,26 @@ SPLITPKG=0
>  SOURCEONLY=0
>  VERIFYSOURCE=0
>  
> +# Errors
> +E_OK=0
> +E_FAIL=1 # Generic error
> +# exit code 2 reserved by bash for misuse of shell builtins
> +E_CONFIG_ERROR=3
> +E_INVALID_OPTION=4
> +E_BUILD_FAILED=5
> +E_PACKAGE_FAILED=6
> +E_MISSING_FILE=7
> +E_MISSING_PKGDIR=8
> +E_INSTALL_DEPS_FAILED=9
> +E_REMOVE_DEPS_FAILED=10
> +E_ROOT=11
> +E_FS_PERMISSIONS=12
> +E_PKGBUILD_ERROR=13
> +E_ALREADY_BUILT=14
> +E_INSTALL_FAILED=15
> +E_MISSING_MAKEPKG_DEPS=16
> +E_PRETTY_BAD_PRIVACY=17

The last one is my favourite error code ever!


My only requested change is to define the error codes in
scripts/libmakepkg/util/error.sh.  I'd like to keep from adding chunks
to makepkg that would easily be placed in libmakepkg.

Thanks,
Allan