[pacman-dev] [PATCH] libmakepkg: Support file 5.33's application/x-pie-executable

[Gabriel C]

2018-04-22 21:53 GMT+02:00 Jan Alexander Steffens <jan.steffens at gmail.com>:
> On Sun, Apr 22, 2018, 18:22 Gabriel C <nix.or.die at gmail.com> wrote:
>
>> I don't think that's  enough .. since everything , .so ,
>> .a ( possible glibc2.7+gcc8 ) and any binary is
>> now marked  application/x-pie-executable in PIE builds.
>>
>> So probably something like this is what you wish :
>>
>>
>> https://github.com/abucodonosor/pacman/commit/f38df66ad39383dbce92cef53d3da7ec19208fed
>
>
> No, I think that's wrong. You're also removing the relocation information
> from the PIE binaries.

So explain why that is wrong and how is different to what is done
right now .. If you say that is wrong then you say is wrong in general.

Also how this removes realocation informations ?
That would be then broken for <file 5.33 ,right ?

Did you run at least plain 'file' to see what file reports now no matter
you have a shared lib , execuable or a static lib ?

$ file ./zstd
./zstd: ELF 64-bit LSB pie executable x86-64, version 1 (SYSV),
dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for
GNU/Linux 4.4.113,
BuildID[sha1]=ad32b90631979b66db1e61d4cf94ae62f74c7656, not stripped


$ file ./libzstd.so.1.3.4
./libzstd.so.1.3.4: ELF 64-bit LSB pie executable x86-64, version 1
(SYSV), dynamically linked,
BuildID[sha1]=f21d565252953c3557f0a02e125bfc483198b5a9, not stripped

 And now that is *not a pie executable* but a shared lib..