[pacman-dev] [PATCH] libmakepkg: Support file 5.33's application/x-pie-executable

[Allan McRae]

On 23/04/18 01:44, Gabriel C wrote:
> 2018-04-22 21:53 GMT+02:00 Jan Alexander Steffens <jan.steffens at gmail.com>:
>> On Sun, Apr 22, 2018, 18:22 Gabriel C <nix.or.die at gmail.com> wrote:
>>
>>> I don't think that's  enough .. since everything , .so ,
>>> .a ( possible glibc2.7+gcc8 ) and any binary is
>>> now marked  application/x-pie-executable in PIE builds.
>>>
>>> So probably something like this is what you wish :
>>>
>>>
>>> https://github.com/abucodonosor/pacman/commit/f38df66ad39383dbce92cef53d3da7ec19208fed
>>
>>
>> No, I think that's wrong. You're also removing the relocation information
>> from the PIE binaries.
> 
> So explain why that is wrong and how is different to what is done
> right now .. If you say that is wrong then you say is wrong in general.
> 

There are two issues here:

1) file sucks.  It is not distinguishing between PIE binaries and libraries.

Has that been reported upstream or are we just working around a bug in
makepkg?  If this is fixed upstream, the fix I will accept into pacman
will be quite different...


2) Once we can detect binaries/libraries correctly again, the default
STRIP_BINARIES in Arch Linux is not suitable for the "PIE by default"
setup.  makepkg.conf needs changed rather than just hiding that...
(FYI, this currently screwing over the Arch glibc PKGBUILD
which uses $STRIP_BINARIES..).

A