[pacman-dev] [PATCH] Make `make distcheck` work again.

[Eli Schwartz]

On 12/2/18 11:02 PM, Allan McRae wrote:
> On 3/12/18 11:44 am, Eli Schwartz wrote:
>> bash-completion uses pkg-config to determine the best installation
>> directory, but this does not take --prefix into account (although it
>> works fine with DESTDIR). The fallback value does attempt to set this
>> based on --prefix.
>>
>> The distcheck uses --prefix, though, which means when attempting to
>> install the results and bash-completion support for pkg-config was
>> detected, it errors out on trying to write to, usually, /usr/share.
>>
>> Tell distcheck to use the prefix-based fallback location instead, as the
>> PKG_CHECK_* override.
>>
> 
> What has changed here?   "make distcheck" has been working for me...
> What configure line do you use to generate the error?

It's a fun error! You only get it when you *do* have bash-completion
installed, since then we rely directly on the pkg-config file to
determine where to install things to.

That's why we need to override it when the pkg-config specified
directory is not writable by the distcheck user.

Of course, the other solution would be if distcheck used DESTDIR instead
of specifying a custom --prefix, but this is enforced by autotools...

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20181202/1efd3808/attachment.asc>