[pacman-dev] [PATCH] libmakepkg/executable: don't rely on scoped value of $ret to flag outcomes

Allan McRae allan at archlinux.org
Tue Dec 4 07:23:14 UTC 2018


On 28/11/18 2:00 pm, Eli Schwartz wrote:
> Elsewhere, we return 1 if a library dropin fails, and when running
> functions in a loop, we use `|| ret=1` to preserve scope. This ensures
> the return value of the function remains useful in isolation. Do the
> same thing here as well.
> 
> Drop trivial function which wraps a dropin that also uses $ret, since
> it's no longer needed.
> 

Thanks - I keep forgetting that the point of libmakepkg is reuseability
in addition to splitting up the massive script...

Allan


More information about the pacman-dev mailing list