[pacman-dev] [PATCH] pacman: better warning message when skipping duplicate targets

[Michael Straube]

Am 09.12.18 um 19:47 schrieb Andrew Gregory:
> On 12/09/18 at 06:31pm, Michael Straube wrote:
>> Change the warning message to reflect the reason when skipping duplicate
>> targets. skipping target -> skipping duplicate target
>>
>> FS#49377
>>
>> Signed-off-by: Michael Straube <michael.straube at posteo.de>
>> ---
>>   src/pacman/remove.c | 2 +-
>>   src/pacman/sync.c   | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Should we just remove the error altogether and move the message to
> DEBUG?  The user doesn't need to do anything in response to it and
> I can't think of any reason a front-end would want to actually die
> from it.  It seems to just be useless line noise that requires
> front-ends to check for it specifically just to ignore it.
> 

Sounds reasonable. On the other hand I can imagine that some people
would complain that too much from what's going on is hidden from the
user. What do others think?


P.S.: You mean?
pm_printf(ALPM_LOG_DEBUG, _("skipping duplicate target: %s\n"), target);