[pacman-dev] [PATCH v2] makepkg --packagelist: just list the built package files we will build

Allan McRae allan at archlinux.org
Thu Feb 8 03:37:31 UTC 2018


On 08/02/18 11:22, Eli Schwartz wrote:
> On 02/07/2018 07:24 PM, Allan McRae wrote:
>> Newline separation should be fine.  makepkg ensures most (all?) of the
>> fields are not allowed to have newlines in them.  If any can, we need to
>> catch that in out PKGBUILD linting and error out.  Probably need to add
>> a check that the fields from makepkg.conf don't have newlines either.
> 
> I was thinking primarily of the fields in makepkg.conf, since AFAICT no
> PKGBUILD fields used in assembling the filename can contain newlines.
> 
> OTOH, both PKGDEST and PKGEXT currently allow this, as do all the other
> directory variables in makepkg.conf
> 
> Should we add a lint_pkgbuild check for all the makepkg.conf variables?
> 

Yes please.   Although, lint_config.sh might be a better place to put
it, as it is not really part of pkgbuild linting.

Allan


More information about the pacman-dev mailing list