[pacman-dev] [PATCH] detect pkghash allocation failure

Allan McRae allan at archlinux.org
Wed Jan 10 00:52:10 UTC 2018


On 08/01/18 10:30, Andrew Gregory wrote:
> If rehash ever failed with a full hash it would return the old hash
> that is already full.  get_hash_position would then loop forever
> because it would never find an empty bucket.
> 
> Signed-off-by: Andrew Gregory <andrew.gregory.8 at gmail.com>
> ---
> 
> We still don't actually handle pkghash creation errors anywhere, but
> at least it won't loop forever anymore.
> 

Ack.

We don't really handle failure well throughout the codebase...


More information about the pacman-dev mailing list