[pacman-dev] [PATCH] Remove checking of pkgver in depends entries

Allan McRae allan at archlinux.org
Thu Jul 19 02:46:25 UTC 2018


This change was introduced to prevent entries like depends=('foo>').  However,
it had the unintended side effect of causing a number of working PKGBUILDs to
fail to build.  This happened when a PKGBUILD defined a variable through
calling a "complex" statement within the PKGBUILD (e.g. a function or
evaluating in a subshell).

While not catching these "issues" can result in incorrect SRCINFO, the
resulting packages are fine.  Stop aborting on these issues until the large
number of broken PKGBUILDs are fix, and the restrictions of the PKGBUILD format
are documented.

Signed-off-by: Allan McRae <allan at archlinux.org>
---
 scripts/libmakepkg/lint_pkgbuild/depends.sh.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/libmakepkg/lint_pkgbuild/depends.sh.in b/scripts/libmakepkg/lint_pkgbuild/depends.sh.in
index 40cdc65a..6d25a317 100644
--- a/scripts/libmakepkg/lint_pkgbuild/depends.sh.in
+++ b/scripts/libmakepkg/lint_pkgbuild/depends.sh.in
@@ -46,10 +46,10 @@ lint_depends() {
 		# remove optional epoch in version specifier
 		ver=${depend##$name@(<|>|=|>=|<=)?(+([0-9]):)}
 		lint_one_pkgname depends "$name" || ret=1
-		if [[ $ver != $depend ]]; then
-			# remove optional pkgrel in version specifier
-			check_pkgver "${ver%-+([0-9])?(.+([0-9]))}" depends || ret=1
-		fi
+#		if [[ $ver != $depend ]]; then
+#			# remove optional pkgrel in version specifier
+#			check_pkgver "${ver%-+([0-9])?(.+([0-9]))}" depends || ret=1
+#		fi
 	done
 
 	eval "$shellopts"
-- 
2.18.0


More information about the pacman-dev mailing list