[pacman-dev] [PATCH 2/3] libmakepkg: implement extendable source protocols

[Eli Schwartz]

On 06/04/2018 02:56 AM, Allan McRae wrote:
>> +			bzr|git|hg|svn)
>> +				(( get_vcs )) || continue
>>  				;;
> 
> Should this be moved into the download_$proto functions?  I'd guess most
> of the dropins would be for other vcs systems, and this is not extendable.
Hmm.

Well, other VCS systems could implement private routines for "return 0"
early on this, but it isn't strictly necessary for here. It's mildly
more verbose, but OTOH it also makes things slightly more obvious. I
guess just for the sake of clarity it should do as you suggested...

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20180604/cbc45b1b/attachment-0001.asc>