[pacman-dev] [PATCH 2/7] libmakepkg: stop printsrcinfo generating empty values

[Dave Reisner]

On Fri, Jun 08, 2018 at 09:37:37PM +0100, Morgan Adamiec wrote:
> > Please don't change this to paper over bad PKGBUILDs.
> 
> the thing is foo= is never declared in the pkgbuild
> 
> A pkgbuild like this:
> 
> pkgname=foo
> pkgver=1
> pkgrel=1
> arch=('any')
> 
> package() {
> depends+=("bar")
> }
> 
> Generates a srcinfo like this:
> 
> pkgbase = foo
> pkgver = 1
> pkgrel = 1
> arch = any
> 
> pkgname = foo
> depends =
> depends = bar
> 
> When you perform foo+=(bar) when foo is unset the array will only
> contain foo. So no I wouldn't put the blame on bad pkgbuilds here.
> 
> Infact the same thing happens if you do declare depends globally like such:
> 
> pkgname=foo
> pkgver=1
> pkgrel=1
> arch=('any')
> depends=()
> 
> package() {
> depends+=("bar")
> }

I see. Thanks for the clear reproduction case -- I think I see the
problem and I'll post a patch for the pkgbuild util code.