[pacman-dev] [PATCH 3/7] libmakepkg: lint disallowed variables in package()

[Eli Schwartz]

On 06/23/2018 10:01 PM, Morgan Adamiec wrote:
> Silly mistakes aside.
> 
>> These are not variables being overridden...   pkgname_i686 is just not a
>> thing as far as makepkg is concerned.
> 
> The point of this is specifically disallow things like 'pkgname_i686'
> rather than just ignore them.

But Allan's point seems to be that we shouldn't try to stop people from
using variables that makepkg does not utilize, just because they look
vaguely like something makepkg might have used.

At a bare minimum, if we are going to ban them, the error message and
entire handling logic should be merged into your next patch.

This error message would have the benefit of being the actual, true
reason we're aborting. (You could check inside the package functions
too, and extend the error message to refer to where they come from.)


-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20180623/ec7be025/attachment-0001.asc>