[pacman-dev] [PATCH] libmakepkg/integrity: fix regression that broke --install

Eli Schwartz eschwartz at archlinux.org
Mon Mar 5 15:41:01 UTC 2018

On 03/05/2018 10:36 AM, Eli Schwartz wrote:
> -	local pkgarch pkg_file
> +	local pkg pkgarch pkg_file
>  	local pkgname_backup=("${pkgname[@]}")
>  	local fullver=$(get_full_version)
>  	msg "$(gettext "Signing package(s)...")"
> -	for pkgname in ${pkgname_backup[@]}; do
> -		pkgarch=$(get_pkg_arch $pkgname)
> -		pkg_file="$PKGDEST/${pkgname}-${fullver}-${pkgarch}${PKGEXT}"
> +	for pkg in "${pkgname[@]}"; do
> +		pkgarch=$(get_pkg_arch $pkg)
> +		pkg_file="$PKGDEST/${pkg}-${fullver}-${pkgarch}${PKGEXT}"
>  		create_signature "$pkg_file"
>  	done
>  	# check if debug package needs a signature
>  	if ! check_option "debug" "y" || ! check_option "strip" "y"; then
BTW any reason we even need to do all this instead of, say, using

We could probably do that both here and in install_package, especially
if/when "makepkg --packagelist: just list the built package files we
will build" is accepted.

See? This patch is even useful for makepkg itself, why would we ever not
want it. :p

Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20180305/7f4361a5/attachment.asc>

More information about the pacman-dev mailing list