[pacman-dev] [PATCH] libmakepkg/integrity: fix regression that broke --install

Eli Schwartz eschwartz at archlinux.org
Thu Mar 15 00:37:13 UTC 2018


On 03/14/2018 01:34 AM, Allan McRae wrote:
>>  	# check if debug package needs a signature
>>  	if ! check_option "debug" "y" || ! check_option "strip" "y"; then
>> -		return
>> +		pkg=$pkgbase- at DEBUGSUFFIX@
>> +		pkgarch=$(get_pkg_arch)
>> +		pkg_file="$PKGDEST/${pkg}-${fullver}-${pkgarch}${PKGEXT}"
> 
> We should check this file exists.   The create_signature function will
> still fail when the package is not there, which can happen if there is
> no binaries in the package. (e.g. arch=any packages).

True -- looks like this was broken for a while now (before
create_package_signatures this was actually run inside the debug
packaging run).

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20180314/8669a3f7/attachment.asc>


More information about the pacman-dev mailing list