[pacman-dev] [PATCH] Extend BUILDENV: Allow for supplemental scripts that enable build-time optimizations.

[Eli Schwartz]

On 05/22/2018 01:29 PM, Que Quotion wrote:
> +for lib in "$LIBRARY/buildenv_ext/"*.sh; do
> +	source "$lib"
> +done

As mentioned in the past by dreisner, this is totally wrong. makepkg
does not set nullglob, which means this causes makepkg to error out
trying to source a nonexistent literal file named "*.sh".

This happens because makepkg does not provide any of our own
buildenv_ext files.

IMHO this whole thing is backwards. We should be moving the existing
prepare_buildenv into libmakepkg, rather than appending to it. Once
prepare_buildenv is implemented as a series of dropin buildenv/*.sh.in,
support for extensions will exist as a matter of course. This is how
every other libmakepkg feature works.

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20180522/02697c8e/attachment.asc>