[pacman-dev] [PATCH] Add meson.build files to build with meson

[Andrew Gregory]

On 10/21/18 at 05:46pm, Dave Reisner wrote:

-- >8 -- (lots of words)

> diff --git a/meson.build b/meson.build
> new file mode 100644
> index 00000000..3f9b2ae0
> --- /dev/null
> +++ b/meson.build
> @@ -0,0 +1,487 @@

-- >8 -- (many more words)

> +PYTHON = find_program('python')

This should look for python3, should it not?

-- >8 -- (I really hope this was mostly copy-paste)

> +libcommon = static_library(
> +  'common',
> +  libcommon_sources,
> +  install : false)

It's a mistake, but common/ini.c currently includes alpm.h, which
grabs the system alpm.h, or dies if it's not installed, because this
doesn't link_with libalpm.  I'll send a patch to fix this particular
error, but I can imagine this sort of subtle error creeping in again.
Should we proactively link_with libalpm to prevent this from
recurring?

-- >8 -- (seriously, this patch is huge)

> diff --git a/test/pacman/meson.build b/test/pacman/meson.build
> new file mode 100644
> index 00000000..dbdb429e
> --- /dev/null
> +++ b/test/pacman/meson.build
> @@ -0,0 +1,357 @@
> +pacman_tests = [
> +  { 'name': 'tests/backup001.py' },

Having the test list and expected success/failure duplicated here is
almost certain to lead to meson and autotools getting out of sync.
Can/should we dynamically create this list at least for as long as
we're maintaining both build systems?