[pacman-dev] [PATCH] makepkg: fix broken check for the fakeroot binary

[Eli Schwartz]

On 11/5/18 3:09 AM, Erich Eckner wrote:
> On 05.11.18 01:06, Eli Schwartz wrote:
>> In commit d8ee8d0c99c3820951e2e49dbdb71a5390bd1dc4 we made use of
>> fakeroot absolutely mandatory, and disabled a lot of the code which
>> checked to see if this now-defunct BUILDENV option was set, before
>> setting up the environment to use fakeroot. Unfortunately, we missed one
>> spot.
>>
>> The check_software routine still checked to see if fakeroot was
>> enabled, but due to the option being removed, thought that it was in
>> fact disabled, and as a result this check would never run.
>>
>> Fix by unconditionally checking for the fakeroot binary. While in
>> theory, users could be using --verifysource or --packagelist or
>> --printsrcinfo without, strictly speaking, needing fakeroot, they are
>> sure to be building the software too, anyway, so this use case is not
>> one we need to support.
> 
> Just let me note here, that archlinux32's build master runs "makepkg
> --printsrcinfo" on a regular basis to determine properties of
> to-be-built packages, but does not build any packages itself. However, I
> see, that this is a rather cornercase which you indeed do not need to
> support: It is rather easy for us to provide all necessities for
> actually building.

So, originally I asked allan whether I should try to do even more fancy
things here, and he said not to bother due to the reasons I mentioned in
the commit message.

Your response inspired him to suggest I handle this use case anyway, and
it also inspired me to do a bit more digging around in check_software(),
and I'm now going submit a more targeted patchset, with some followups
to handle some other issues nearby as well!

-- 
Eli Schwartz
Bug Wrangler and Trusted User

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20181113/dbfa4716/attachment.asc>