[pacman-dev] [PATCH v2] libalpm: parse {check, make}depends when reading database

Morgan Adamiec morganamilo at gmail.com
Tue Oct 9 01:20:51 UTC 2018


On 09/10/2018 2:15 am, Allan McRae wrote:
> On 9/10/18 11:05 am, morganamilo wrote:
>>  static struct pkg_operations local_pkg_ops = {
>> -	.get_base        = _cache_get_base,
>> -	.get_desc        = _cache_get_desc,
>> -	.get_url         = _cache_get_url,
>> -	.get_builddate   = _cache_get_builddate,
>> -	.get_installdate = _cache_get_installdate,
>> -	.get_packager    = _cache_get_packager,
> <snip>
>> +	.get_base         = _cache_get_base,
>> +	.get_desc         = _cache_get_desc,
>> +	.get_url          = _cache_get_url,
>> +	.get_builddate    = _cache_get_builddate,
>> +	.get_installdate  = _cache_get_installdate,
> ...
> 
> Is there any objection to killing this formatting rather than having a
> lot of uselessness in the patch.
> 
> A
> 

I could split adding the fields and the formatting to two patches if you
prefer? Easier to read diffs and the struct stays pretty.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.archlinux.org/pipermail/pacman-dev/attachments/20181009/6b27f4db/attachment-0001.asc>


More information about the pacman-dev mailing list